feat(ui): implement commands#75
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis PR introduces a comprehensive Design System Gallery app and updates CI/CD workflows and lint configurations. It adds new GitHub workflows for publishing the gallery and updating golden files, expands the PR workflow's branch filters and semantic commit scopes, updates Flutter SDK to v6 in CI, modernizes linting rules, and implements an extensive Widgetbook-based gallery showcasing design system components with interactive playgrounds and static showcases. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can get early access to new features in CodeRabbit.Enable the |
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (67.46%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main-design-system #75 +/- ##
=====================================================
Coverage ? 35.32%
=====================================================
Files ? 117
Lines ? 3660
Branches ? 0
=====================================================
Hits ? 1293
Misses ? 2367
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…/implement-commands
| vertical: spacing.xxxs, | ||
| ); | ||
|
|
||
| BorderRadius get borderRadius => const BorderRadius.all(Radius.circular(9999)); |
| color: effectiveBackgroundColor, | ||
| borderRadius: defaults.borderRadius, | ||
| ), | ||
| constraints: const BoxConstraints(minHeight: 24), |
There was a problem hiding this comment.
maybe also add minHeight to theme?
| size: 12, | ||
| color: effectiveIconColor, | ||
| ), | ||
| SizedBox(width: defaults.spacing.xxxs), |
There was a problem hiding this comment.
we can use Row.spacing instead
There was a problem hiding this comment.
I generally always extend the default from the actual themeData class StreamCommandChipThemeData so that we can be sure all the field are also in the themeData.
Like here we missed adding padding and borderRadius
Submit a pull request
Linear: FLU-409
CLA
Description of the pull request
This adds the command chip to the core library
Screenshots / Videos
Summary by CodeRabbit
New Features
Chores